Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backup table detection bug in acl-config. #920

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix backup table detection bug in acl-config. #920

merged 2 commits into from
May 7, 2019

Conversation

ryanrath
Copy link
Contributor

@ryanrath ryanrath commented May 7, 2019

Description

So it turns out that PHP prepared statement variable binding doesn't play well
with SQL IN statements. Just moving things around a bit so that instead of
supplying the IN clause w/ a bind parameter we instead just populate it in the
base query string.

This PR is related to: https://ubccr.freshdesk.com/a/tickets/12470

Motivation and Context

It's nice to have a recover mode that actually functions

Tests performed

Manual Tests performed on a local docker instance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ryanrath
Updated SQL construction for tablesExist
2dd89e1 
So it turns out that PHP prepared statement variable binding doesn't play well
with SQL `IN` statements. Just moving things around a bit so that instead of
supplying the `IN` clause w/ a bind parameter we instead just populate it in the
base query string.
@ryanrath ryanrath added the bug Bugfixes label May 7, 2019
@ryanrath ryanrath added this to the 8.5.0 milestone May 7, 2019
@jtpalmer jtpalmer added the Category:ACL Access Control Lists label May 7, 2019
@ryanrath ryanrath merged commit 5ee31bd into ubccr:xdmod8.5 May 7, 2019
@jpwhite4 jpwhite4 changed the title Updated SQL construction for tablesExist Fix backup table detection bug in acl-config. Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakrabortyr chakrabortyr chakrabortyr left review comments

@jtpalmer jtpalmer jtpalmer approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:ACL Access Control Lists
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanrath @jtpalmer @chakrabortyr